Skip to content

Working on howto/sockets.po#621

Merged
JulienPalard merged 10 commits into
python:3.7from
vtrubesset:howto-sockets
Apr 3, 2019
Merged

Working on howto/sockets.po#621
JulienPalard merged 10 commits into
python:3.7from
vtrubesset:howto-sockets

Conversation

@vtrubesset

Copy link
Copy Markdown

Closes #611

@Seluj78 Seluj78 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup pour la PR ! Et nice le closes #, super touch toujours utile et tout le monde n'y pense pas ;) Vous avez été bien formé 😇

Relu pour la syntaxe RST principalement pour l'instant

Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Vincent Trubesset and others added 2 commits March 22, 2019 00:37
Non-breaking spaces & emphasis

Co-Authored-By: trubesv <vincent.trubesset@gmail.com>
@Seluj78

Seluj78 commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

@trubesv tu peux appliquer les suggestions depuis github sans force push si besoin du coup

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette contribution.
Je pense que l'on peut utiliser « connecteur » dans cette page, en précisant en début de page que ce mot désigne l'anglais « socket ».

Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated

@JulienPalard JulienPalard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Comment thread howto/sockets.po Outdated
Comment thread howto/sockets.po Outdated
JulienPalard and others added 2 commits March 30, 2019 14:02
Co-Authored-By: trubesv <vincent.trubesset@gmail.com>
@JulienPalard
JulienPalard merged commit b8ad383 into python:3.7 Apr 3, 2019
@JulienPalard

Copy link
Copy Markdown
Member

Top merci pour ta PR :))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants